Run results for: loop vs some

Run details:

User agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Firefox/73.0

Browser: Firefox 73

Operating system: Linux

Device Platform: Desktop

Date tested: 4 years ago

Test name	Executions per second
For Loop	49465.9 Ops/sec
Some	20506.9 Ops/sec

Script Preparation code:

function validatePersonSome(person, isCmsgOrgs, selectedOrgs) {
  if (isCmsgOrgs) {
    // If a person has service_groups it will check them against the org SERVICE_GROUP_IDS, if a match is found that person will be selectable
    if (person.service_groups.length) { // eslint-disable-line mp-camelcase
      return person.service_groups.some(function(service_group) { // eslint-disable-line mp-camelcase
        return selectedOrgs.some(function(org) {
          return org.SERVICE_GROUP_IDS.some(function(org_service_group) { // eslint-disable-line mp-camelcase
            return org_service_group.SERVICE_GROUP_ID === service_group.id; // eslint-disable-line mp-camelcase
          });
        });
      });
    } else {
      return false;
    }
  }
  // If no orgs contain SERVICE_GROUP_IDS, only those persons with no service_groups will be selectable
  else {
    return person.service_groups.length === 0;
  }
}

function validatePersonLoop(person, hasCmsgOrgs, selectedOrgs) {
  var isValid = false;

  if (hasCmsgOrgs) {
    // If a person has service_groups it will check them against the org SERVICE_GROUP_IDS, if a match is found that person will be selectable
    if (person.service_groups.length) {
      var orgServiceGroupIds = {};
      var org;

      for (var i = 0; i < selectedOrgs.length; i++) {
        org = selectedOrgs[i];
        for (var j = 0; j < org.SERVICE_GROUP_IDS.length; j++) {
          orgServiceGroupIds[org.SERVICE_GROUP_IDS[j].SERVICE_GROUP_ID] = true;
        }
      }

      for (var i = 0; i < person.service_groups.length; i++) {
        if (orgServiceGroupIds[person.service_groups[i].id]) {
          isValid = true;
          break;
        }
      }
    }
  }
  // If no orgs contain SERVICE_GROUP_IDS, only those persons with no service_groups will be selectable
  else {
    isValid = person.service_groups.length === 0;
  }

  return isValid;
}

Tests:

For Loop
var person = {}; person.service_groups = []; for (var i = 0; i < 1000; i++) { person.service_groups.push({ id: i }); } var selectedOrgs = []; selectedOrgs.push({ "ORGANIZATION_ID": "12345", "ORG_NAME": "some_name", "SERVICE_GROUP_IDS": [{ service_group_id: 1 }] }); validatePersonLoop(person, true, selectedOrgs);
Some
var person = {}; person.service_groups = []; for (var i = 0; i < 1000; i++) { person.service_groups.push({ id: i }); } var selectedOrgs = []; selectedOrgs.push({ "ORGANIZATION_ID": "12345", "ORG_NAME": "some_name", "SERVICE_GROUP_IDS": [{ service_group_id: 1 }] }); validatePersonSome(person, true, selectedOrgs);

Run results for: loop vs some

Tests for loops vs array.some

For Loop

Some